Validate CoinPay CLI payment arguments by rissrice2105-agent · Pull Request #629 · profullstack/sh1pt

rissrice2105-agent · 2026-06-05T22:45:27Z

Fixes #628.

Changes:

validate CoinPay create amount as a positive number
validate optional businessId before adding it to CLI args
normalize and validate blockchain/coin/fiat asset codes
require paymentId for get commands
add tests proving invalid configs do not call the external CoinPay CLI

Validation:

vitest run packages/targets/payment-coinpay/src/index.test.ts
tsc -p packages/targets/payment-coinpay/tsconfig.json --noEmit

greptile-apps · 2026-06-05T22:49:30Z

Greptile Summary

This PR adds pre-flight validation to the CoinPay CLI target adapter, catching bad arguments (non-positive amounts, blank IDs, malformed asset codes) before the external coinpay CLI is ever invoked, and normalises coin/fiat/blockchain codes to uppercase. It also removes requiredSecrets (an unused property on TargetContractOptions) and adds a focused Vitest suite covering each validation path.

Input guards added: requirePositiveAmount, requireText, optionalText, and requireAssetCode cover all four command handlers; the requireAssetCode helper also applies a strict ^[A-Z0-9_]{2,16}$ format check after normalisation.
Test coverage: six new test cases exercise the happy path for create and rates plus all four rejection paths (zero amount, blank businessId, whitespace-only paymentId, and malformed coin code).

Confidence Score: 4/5

Safe to merge; the validation logic is correct for all normal inputs and the tests prove the key rejection paths.

The validation helpers work correctly and the test suite covers the main paths. The only notable gap is that requireAssetCode uses === undefined for its fallback guard rather than nullish coalescing, so an explicit null coin/fiat bypasses the default and surfaces a misleading required error.

packages/targets/payment-coinpay/src/index.ts — specifically the requireAssetCode fallback and the optional blockchain field in the create handler.

Important Files Changed

Filename	Overview
packages/targets/payment-coinpay/src/index.ts	Adds input validation helpers (requireText, optionalText, requirePositiveAmount, requireAssetCode) and wires them into all four command handlers; minor issue with null vs undefined handling in requireAssetCode fallback logic.
packages/targets/payment-coinpay/src/index.test.ts	Adds targeted unit tests covering positive validation, amount rejection, blank businessId, missing paymentId, asset code normalisation, and malformed code rejection; mock setup and cleanup look correct.

_{Reviews (1): Last reviewed commit: "Validate CoinPay CLI payment arguments" | Re-trigger Greptile}

greptile-apps · 2026-06-05T22:49:33Z

+}
+
+function requireAssetCode(value: unknown, name: string, fallback?: string): string {
+  const raw = value === undefined ? fallback : value;


The fallback in requireAssetCode only fires when value === undefined, which means explicitly passing null (a valid unknown value in Record<string, unknown>) bypasses the default and falls through to requireText(null, name), which throws "coin required" instead of using the fallback. The more conventional JavaScript idiom for "treat null and undefined the same" is nullish coalescing, which would correctly apply the fallback for both.

Suggested change

const raw = value === undefined ? fallback : value;

const raw = value ?? fallback;

greptile-apps · 2026-06-05T22:49:34Z

-        if (config.args?.blockchain) args.push('--blockchain', String(config.args.blockchain));
+        const amount = requirePositiveAmount(config.args?.amount);
+        args.push('--amount', String(amount));
+        if (config.args?.blockchain) args.push('--blockchain', requireAssetCode(config.args.blockchain, 'blockchain'));


Missing blockchain field validation for create — blockchain is optional here but may be required by the CoinPay CLI. If omitted, the CLI invocation goes out without --blockchain and any resulting error surfaces as an opaque CLI failure rather than an early, clear validation message. Consider making the field required for create (or documenting that the CLI has a default).

github-actions · 2026-06-06T07:10:34Z